Always forward fputc to original fputc, with or without colors #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cehoffman
reviewed
Jun 29, 2017
src/stderred.c
Outdated
| @@ -164,6 +194,14 @@ int FUNC(fprintf)(FILE *stream, const char *format, ...) { | |||
| return result; | |||
| } | |||
|
|
|||
| int FUNC(__fprintf_chk)(FILE *fp, int flag, const char *format, ...) { | |||
There was a problem hiding this comment.
This function needs to be put behind a #ifdef check for existence since it is non standard.
See https://github.com/sickill/stderred/blob/master/src/CMakeLists.txt#L38-L50 for how
|
Thank for this @DanOlivier, I think these are good changes. |
|
Changes pertaining to __fprintf_chk are in pull #57. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So LD_PRELOAD will affect every process forked from the console.
I hit an application that was affected by the fact that fputc was being silently redirected to fwrite (despite blacklisting).
The bug (see #53) was probably due to the differences in the meaning of the return codes.
To improve safety, this change (pull request) will not redirect the calls: fputc calls fputc, fwrite calls fwrite, and both will insert coloring commands before and after.