[CORRECTION NEEDED] KULRICE-14124: Fixed an issue where returning a document to a previous n... #62
Conversation
…s node was causing an error when the document is at the final approval *Fixed an issue where returning a document to a previous node was causing an error when the document is at the final approval node, even though no action was taken at that node. * Added an IT to test the fix
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Hi @ssaripel, is the testFinalApprovalNodeReturnToPrevious() working as it shoud? I ran the test against our current code (without any of the contributed fixes) and the test passed. |
|
@cniesen I ran this test against the foundation rice code we use and without the fix the test failed. Can you point me to which code you ran it against? |
|
Not enough memory was allocated for the test I ran and IntelliJ reported it as passing instead of a failure. Not good. Anyway, I could reproduce the exception which is fixed with your patch. |
| @@ -44,4 +45,6 @@ | |||
| */ | |||
| Timestamp getLastActionTakenDate(String documentId, ActionType actionType); | |||
|
|
|||
| List<ActionTakenValue> findActionsTakenAtRouteNodeInstance(RouteNodeInstance nodeInstance); | |||
|
@ssaripel Can you make these changes and update this pull request? Hint:
|
cniesen
changed the title
|
Thanks for the contribution. We like to have the two commits "squashed" together into one. I went ahead and squashed them in pull request #106 and closed this pull request. |
fixing nexus release #norelease
...ode was causing an error when the document is at the final approval
*Fixed an issue where returning a document to a previous node was
causing an error when the document is at the final approval node, even
though no action was taken at that node.