Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multimodal graph linking not working? #153

Open
HTenkanen opened this issue Oct 1, 2019 · 2 comments
Open

Multimodal graph linking not working? #153

HTenkanen opened this issue Oct 1, 2019 · 2 comments

Comments

@HTenkanen
Copy link

HTenkanen commented Oct 1, 2019

Hi again @kuanb,

I continued digging around (see #124) and tested using the existing_graph -parameter to link walking and PT graphs together. I found that the stops around transit areas are connected together, but edges that would link stops to road network does not seem to work (as in the example below). Is this expected behavior?

image

The code that I used to produce the graph is:

G = pt.load_feed_as_graph(feed, start, end, 
                                 walk_speed_kmph=walk_speed,
                                 impute_walk_transfers=False,
                                 use_multiprocessing=True,
                                 existing_graph=walk_graph)
@kuanb
Copy link
Owner

kuanb commented Oct 8, 2019

Interesting - I will look into this further! Thank you for flagging!

@d3netxer
Copy link
Contributor

I looked into this, and this is connected to the 'hanging nodes' issue from the peartree with walk tutorial: http://kuanbutts.com/2018/12/24/peartree-with-walk-network/

When a network is obtained via OSMNX the node IDs are ints, so we want to preserve these ints instead of converting them to strings. Or else, we will be creating hanging nodes and also be ignoring nearest nodes that come from the existing graph. I am submitting this pull request: #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants