Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserving node id types from original graph #164

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

d3netxer
Copy link
Contributor

fixes 'hanging nodes' and issue #153

@kuanb
Copy link
Owner

kuanb commented Jan 13, 2021

Thanks @d3netxer I see 2 main changes in this PR:

  1. indexes are kept as numerical values and not strings
  2. make sure that cross feed edges get both to and from (bi-diretional)

I've got a question about 1 - did you find this would problematic and causing the hanging node issues and adjusting 1 alone did not address the issue? I can look into it further.

@d3netxer
Copy link
Contributor Author

@kuanb adjusting 1 alone fixed the hanging node issue. This would create cross-edges in one direction connecting stops to nearby OSM nodes. However, I noticed that in some cases in my graph, the faster transit line wasn't being included in the shortest path. This was because a one-directional edge went either from the OSM node to the stop, therefore a rider could not get off the stop. Or a a one-directional edge went only from the stop to the OSM node, and therefore a rider could only get off the stop, but not get on. Therefore I added bi-directional edges in 2.

@d3netxer
Copy link
Contributor Author

I would like to have the option to add an attribute to graph edges that represents the number of trips that pass through an edge. This would be good to checking my GTFS data. I am making a pull request that adds this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants