Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 2 graph creation steps #26

Merged
merged 5 commits into from
Mar 4, 2018
Merged

Refactor 2 graph creation steps #26

merged 5 commits into from
Mar 4, 2018

Conversation

kuanb
Copy link
Owner

@kuanb kuanb commented Mar 4, 2018

The two graph creation functions in graph.py have a lot of redundant operations. These are the funcs:

  • populate_graph
  • make_synthetic_system_network

This PR seeks to consolidate a number of those repeat operations into helper functions.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 89.423% when pulling 104c491 on kuanb-refactor-graph into 7dd6ff0 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 89.423% when pulling 104c491 on kuanb-refactor-graph into 7dd6ff0 on master.

@kuanb kuanb merged commit d4e1c84 into master Mar 4, 2018
@kuanb kuanb deleted the kuanb-refactor-graph branch March 4, 2018 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants