Parameterize close-node edge creation on new nodes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuanb
changed the title
kuanb
force-pushed
the
kuanb-parameterize-internal-exempt
branch
from
46044e6
to
0bb5420
Compare
|
Also note worked in some pending issues into how connector edges are created, specifically on line https://github.com/kuanb/peartree/pull/30/files#diff-a6c4e8f23a23fd98f4100282fd75c44bR84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we add a 2nd (3rd, 4th...) GTFS to an existing graph, we attempt to find connections between the two systems that are close and make them low/no-cost edge connectors.
This adds a parameter to make such it optional to exempt the new nodes from this step. Typically, you would do this with schedule data as the GTFS schedule should itself have the connections built in.
BUT when building stops and edges from a "synthetic" path, we want to make sure that we also create edges between the new paths created since they will not be naturally synced with each other (or each direction, for that matter).