Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass MZ_ZIP_GENERAL_PURPOSE_BIT_FLAG_UTF8 #214

Merged
merged 1 commit into from
Dec 10, 2021
Merged

pass MZ_ZIP_GENERAL_PURPOSE_BIT_FLAG_UTF8 #214

merged 1 commit into from
Dec 10, 2021

Conversation

kuba--
Copy link
Owner

@kuba-- kuba-- commented Dec 9, 2021

...to mz_zip_writer_add_to_central_dir

UAchar
UAchar approved these changes Dec 10, 2021
View reviewed changes
Copy link

@UAchar UAchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works.. Thanks!

@UAchar
Copy link

UAchar commented Dec 10, 2021

Also, would it be possible to have a release version soon?
The fix may be is trivial but being able to extract and view a Kuba Zip file with other zip tools properly is a major step for us.

@kuba-- kuba-- merged commit 72cb23c into master Dec 10, 2021
@kuba-- kuba-- deleted the MZ_ZIP_GENERAL_PURPOSE_BIT_FLAG_UTF8 branch December 10, 2021 11:14
@kuba--
Copy link
Owner Author

kuba-- commented Dec 10, 2021

@UAchar - here you go:
https://github.com/kuba--/zip/releases/tag/v0.2.1

thabetx pushed a commit to Symbyo360/zip that referenced this pull request Sep 7, 2023
@kuba-- @thabetx
pass MZ_ZIP_GENERAL_PURPOSE_BIT_FLAG_UTF8 to mz_zip_writer_add_to_cen…
c0beeb1 
…tral_dir (kuba--#214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UAchar UAchar UAchar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuba-- @UAchar