for support shareable file open on windows #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
reviewed
Dec 22, 2021
kuba--
approved these changes
Dec 23, 2021
thabetx
pushed a commit
to Symbyo360/zip
that referenced
this pull request
Sep 7, 2023
Support shareable file open on windows Co-authored-by: visla-dragon <visla-dragon@visla.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the cmake in my local repo, please help to check if the macro name is suitable , also I met one crash
in zip_entry_open for zip is nullptr because my wrong usage, so I changed the time pointer of check null pointer