Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
zip_open("somefile.zip", 0, 'r');
fails ifsomefile.zip
is read-only.To test this, just add a call to
chmod(ZIPNAME, S_IRUSR);
(needssys/stat.h
included) to the end oftest_setup()
intest/test_read.c
.The reason for this is that
'r'
uses this:zip/src/zip.c
Line 847 in 114d9d4
..which in turn uses this:
zip/src/miniz.h
Line 5999 in 114d9d4
An
fopen()
with moder+
means that it's opened read-write.This PR fixes it by using
mz_zip_reader_init_file_v2()
(which opens inrb
mode, notr+b
mode) when opening files in'r'
mode.This fix should help with the downstream issue SuperIlu/DOjS#28