Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix #123 #344

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Try to fix #123 #344

merged 1 commit into from
Mar 25, 2024

Conversation

kuba--
Copy link
Owner

@kuba-- kuba-- commented Mar 24, 2024

@ouuan
Copy link

ouuan commented Mar 25, 2024

The old PoC still works on my machine 🤔

@kuba--
Copy link
Owner Author

kuba-- commented Mar 25, 2024

The old PoC still works on my machine 🤔

I've refined zip_name_normalize function, so hopefully it's fixed as expected.

@ouuan
Copy link

ouuan commented Mar 25, 2024

According to the tests, I also believe that it's fixed now.

@ouuan
Copy link

ouuan commented Mar 25, 2024

BTW, just a small reminder, you can use fixes #342 instead of fixes https://github.com/kuba--/zip/issues/342 to link to the issue and automatically close it on PR merge. ref: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@kuba-- kuba-- merged commit 6f2116d into master Mar 25, 2024
10 checks passed
@kuba-- kuba-- deleted the fix-123 branch March 25, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants