Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift support, improved styling support #2

Merged
merged 9 commits into from Oct 21, 2016

Conversation

Legoless
Copy link
Contributor

This pull request adds 3 features:

  • Swift API enhanced compatibility with Nullability modifiers
  • Ability to style buttons added to the alert view by providing a custom block
  • Ability to choose color for button separator

@kubatruhlar
Copy link
Owner

kubatruhlar commented Oct 20, 2016

Nice job, would you mind to remove extra double spaces (line 135 etc.) and space behind the * (like line 94, 24 etc.)?

@Legoless
Copy link
Contributor Author

Something like this? :)

@kubatruhlar
Copy link
Owner

I mean UIButton* btn should be UIButton *btn in .h and in .m as well. Otherwise its good 👍

@Legoless
Copy link
Contributor Author

I'm not sure what you mean, they are the same on both sides?

@kubatruhlar
Copy link
Owner

It's just a style preference, the space doesn't mean anything in this case, but keep the style of this code please.

@Legoless
Copy link
Contributor Author

Of course, I'm keeping style the same, but maybe just Xcode formats it in a way I cannot see what you want changed. Can you be more specific?

@kubatruhlar
Copy link
Owner

Don't you see space after asterix? Everywhere you put UIButton* btn, you are supposed to put the space before not after the asterix.

@Legoless
Copy link
Contributor Author

Oh yeah, that's what you mean, sorry :) Fixed now, I hope.

@kubatruhlar kubatruhlar merged commit a9fe458 into kubatruhlar:master Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants