Do not require mbstring extension

kubawerlos · Mar 20, 2020 · f628dd8 · f628dd8
1 parent 7cfd886
commit f628dd8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -38,7 +38,6 @@ jobs:
         with:
           php-version: ${{ matrix.php-version }}
           coverage: pcov
-          extensions: mbstring
 
       - name: Get composer cache directory
         id: composer-cache

diff --git a/composer.json b/composer.json
@@ -11,7 +11,6 @@
     ],
     "require": {
         "php": "^7.2",
-        "ext-mbstring": "*",
         "ext-tokenizer": "*",
         "symfony/console": "^3.4 || ^4.0 || ^5.0",
         "symfony/finder": "^3.4 || ^4.0 || ^5.0"

diff --git a/src/Command/CheckCommand.php b/src/Command/CheckCommand.php
@@ -58,7 +58,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $output->writeln('');
 
         $whatWasChecked = $this->getWhatWasChecked($report);
-        if (\mb_strpos($whatWasChecked, 'item') !== false) {
+        if (\strpos($whatWasChecked, 'item') !== false) {
             $output->writeln(\sprintf('Types checker - %s checked:', $whatWasChecked));
             if ($report->getNumberOfClasses() > 0) {
                 $output->writeln(\sprintf(' - %s', $this->pluralize($report->getNumberOfClasses(), 'class')));
@@ -121,7 +121,7 @@ private function getWhatWasChecked(Report $report): string
     private function pluralize(int $count, string $name): string
     {
         if ($count !== 1) {
-            $name .= \mb_substr($name, -1) === 's' ? 'es' : 's';
+            $name .= \substr($name, -1) === 's' ? 'es' : 's';
         }
 
         return \sprintf('%d %s', $count, $name);