Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network timeout #15

Merged
merged 4 commits into from
Aug 16, 2020
Merged

network timeout #15

merged 4 commits into from
Aug 16, 2020

Conversation

golanha
Copy link
Member

@golanha golanha commented Aug 16, 2020

No description provided.

Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golanha)


hkube_python_wrapper/config/config.py, line 26 at r1 (raw file):

 "timeout": getIntEnv('DISCOVERY_TIMEOUT', 1000),

change this to: 10000
because it took 3000 to get 500Mb.

Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golanha)

@golanha golanha merged commit 5e815b3 into master Aug 16, 2020
hkube-ci pushed a commit that referenced this pull request Aug 16, 2020
network timeout .... bump version [skip ci]
@nassiharel nassiharel deleted the network_timeout branch September 8, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants