Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise proper storage manager exceptions #18

Merged
merged 1 commit into from
Aug 25, 2020
Merged

raise proper storage manager exceptions #18

merged 1 commit into from
Aug 25, 2020

Conversation

yehiyam
Copy link
Contributor

@yehiyam yehiyam commented Aug 25, 2020 •
edited by maty21

This change is Reviewable

nassiharel
nassiharel approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@yehiyam yehiyam merged commit 3b952ae into master Aug 25, 2020
hkube-ci pushed a commit that referenced this pull request Aug 25, 2020
raise proper storage manager exceptions (#18) .... bump version [skip…
8631c73 
… ci]
@yehiyam yehiyam deleted the storage-exceptions branch August 25, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nassiharel nassiharel nassiharel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yehiyam @nassiharel