Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource #16

Merged
merged 10 commits into from
Jan 18, 2021
Merged

Datasource #16

merged 10 commits into from
Jan 18, 2021

Conversation

reggev
Copy link
Contributor

@reggev reggev commented Jan 18, 2021

This change is Reviewable

Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @reggev)


lib/storage-manager.js, line 22 at r1 (raw file):

Object.values(STORAGE_PREFIX)

This is bad....
Each client will need to do Object.values

Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @reggev)


lib/storage-manager.js, line 5 at r1 (raw file):

const { STORAGE_PREFIX } = require('../consts/storage-prefix');

you can add line here
const PREFIXES = Object.values(STORAGE_PREFIX);

and then
async init(config, log, bootstrap = false, prefixes = PREFIXES) {

Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @reggev)

@nassiharel nassiharel merged commit 67a20b1 into master Jan 18, 2021
@nassiharel nassiharel deleted the datasource branch January 18, 2021 14:48
github-actions bot pushed a commit that referenced this pull request Jan 18, 2021
Datasource .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants