Don't override maxWaitTimeout in job spec #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhangShuaiyi
force-pushed
the
bugfix/MaxWaitTimeout
branch
2 times, most recently
from
6855805
to
9660b87
Compare
ZhangShuaiyi
changed the title
rsevilla87
requested review from
shashank-boyapally
and removed request for
shashank-boyapally
rsevilla87
reviewed
Apr 17, 2024
pkg/burner/job.go
Outdated
Comment on lines
322
to
325
| log.Debugf("job.MaxWaitTimeout is zero, override by timeout:%s", timeout) | ||
| job.MaxWaitTimeout = timeout | ||
| } else { | ||
| log.Debugf("job.MaxWaitTimeout is non zero:%s", job.MaxWaitTimeout) |
There was a problem hiding this comment.
Suggested change
| log.Debugf("job.MaxWaitTimeout is zero, override by timeout:%s", timeout) | |
| job.MaxWaitTimeout = timeout | |
| } else { | |
| log.Debugf("job.MaxWaitTimeout is non zero:%s", job.MaxWaitTimeout) | |
| log.Debugf("job.MaxWaitTimeout is zero in %s, override by timeout: %s", job.Name, timeout) | |
| job.MaxWaitTimeout = timeout | |
| } else { | |
| log.Debugf("job.MaxWaitTimeout is non zero %s: %s", job.Name, job.MaxWaitTimeout) |
There was a problem hiding this comment.
Done.
[root@devnode1 kubelet-density]# grep maxWaitTimeout kubelet-density.yml
maxWaitTimeout: 10m
[root@devnode1 kubelet-density]# kube-burner --log-level debug init -c kubelet-density.yml 2>&1 | grep job.MaxWaitTimeout
time="2024-04-17 08:26:35" level=debug msg="job.MaxWaitTimeout is non zero in kubelet-density: 10m0s" file="job.go:325"
[root@devnode1 kubelet-density]# sed -i 's/maxWaitTimeout/#maxWaitTimeout/g' kubelet-density.yml
[root@devnode1 kubelet-density]# grep maxWaitTimeout kubelet-density.yml
#maxWaitTimeout: 10m
[root@devnode1 kubelet-density]# kube-burner --log-level debug init -c kubelet-density.yml 2>&1 | grep job.MaxWaitTimeout
time="2024-04-17 08:27:24" level=debug msg="job.MaxWaitTimeout is zero in kubelet-density, override by timeout: 4h0m0s" file="job.go:322"
[root@devnode1 kubelet-density]#
rsevilla87
requested changes
Apr 17, 2024
Signed-off-by: Shuaiyi Zhang <zhangsy28@lenovo.com>
ZhangShuaiyi
force-pushed
the
bugfix/MaxWaitTimeout
branch
from
9660b87
to
fdbee5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
job.MaxWaitTimeoutinUnmarshalYAMLjob.MaxWaitTimeoutonly if it is emptyRelated Tickets & Documents