Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate job.Namespace when it's non empty. #627

Merged
merged 1 commit into from
Apr 23, 2024
Merged

validate job.Namespace when it's non empty. #627

merged 1 commit into from
Apr 23, 2024

Conversation

ZhangShuaiyi
Copy link
Contributor

@ZhangShuaiyi ZhangShuaiyi commented Apr 22, 2024 •
edited

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Skip validation.IsDNS1123Subdomain when job.Namespace is empty.

Related Tickets & Documents

@ZhangShuaiyi
validate job.Namespace when it's non empty.
7247375 
Signed-off-by: Shuaiyi Zhang <zhang_syi@qq.com>
rsevilla87
rsevilla87 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsevilla87 rsevilla87 merged commit cdb67e1 into kube-burner:main Apr 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsevilla87 rsevilla87 rsevilla87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] job.name can not empty
2 participants
@ZhangShuaiyi @rsevilla87