Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported FieldSelector in waitForPVC #632

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ZhangShuaiyi
Copy link
Contributor

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

waitForPVC does not work, kube-burner will not wait pvc to be Bound before deleting pvc.
PersistentVolumeClaim does not support field-selector status.phase

[root@master-1 ~]# kubectl get pvc --field-selector status.phase!=Bound
Error from server (BadRequest): Unable to find "/v1, Resource=persistentvolumeclaims" that match label selector "", field selector "status.phase!=Bound": "status.phase" is not a known field selector: only "metadata.name", "metadata.namespace"

Only Pod and Namespace support status.phase Field.
https://kubernetes.io/docs/concepts/overview/working-with-objects/field-selectors/#list-of-supported-fields

Related Tickets & Documents

  • Related Issue #
  • Closes #

Signed-off-by: Shuaiyi Zhang <zhang_syi@qq.com>
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks for the thorough analysis

@vishnuchalla vishnuchalla merged commit 8e0f1fe into kube-burner:main Apr 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants