Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for multiple metric profiles #638

Merged
merged 1 commit into from
May 3, 2024
Merged

Adding support for multiple metric profiles #638

merged 1 commit into from
May 3, 2024

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented May 1, 2024 •
edited

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Support for multiple metric profiles in the index sub-command.

Testing

Added a CI test and verified it locally.

kube-burner index --uuid="${UUID}" -u http://localhost:9090 -m "metrics-profile.yaml,metrics-profile.yaml" --tarball-name=metrics.tgz

@vishnuchalla
Adding support for multiple metric profiles
65a6205 
Signed-off-by: KBOCPDocs <vishnuchalla47@gmail.com>
rsevilla87
rsevilla87 approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsevilla87 rsevilla87 merged commit 02222d7 into kube-burner:main May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsevilla87 rsevilla87 rsevilla87 approved these changes

@afcollins afcollins Awaiting requested review from afcollins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vishnuchalla @rsevilla87