Fix/lb upgrade

[mysticaltech]

This fixes the 2.8.x upgrade identified in #1028.

[Silvest89]

@mysticaltech
I would add a delete_protection = true on the loadbalancer resource else the hcloud controller can still delete it. This way it ignores it.

Official docs

If you delete this Service in Kubernetes, the hcloud-cloud-controller-manager will delete the associated Load Balancer. If the Load Balancer is managed through Terraform, this causes problems. To disable this, you can enable deletion protection on the Load Balancer, this way hcloud-cloud-controller-manager will just skip deleting it when the associated Service is deleted.

[mysticaltech]

@mysticaltech I would add a delete_protection = true on the loadbalancer resource else the hcloud controller can still delete it. This way it ignores it.

Official docs

If you delete this Service in Kubernetes, the hcloud-cloud-controller-manager will delete the associated Load Balancer. If the Load Balancer is managed through Terraform, this causes problems. To disable this, you can enable deletion protection on the Load Balancer, this way hcloud-cloud-controller-manager will just skip deleting it when the associated Service is deleted.

Most definitely. Now I understand better what you were mentioning before. Will do! 🙏

[mysticaltech]

@Silvest89 I tried, but it turns out that the delete protection is way too strong and just refuses to delete by any means we use now. Unless the cluster name or ingress_controller changes, there is no reason for terraform to ever delete it! So going to merge without this for now.

[mysticaltech]

@kube-hetzner/core Merging without review as it's been 24h and it's an urgent fix. Thanks for your understanding folks.