Publish traefik service by default, and allow custom namespace target for the ingress_controllers #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silvest89
force-pushed
the
traefik-publish-custom-namespace
branch
from
9a2c07c
to
930513a
Compare
mysticaltech
approved these changes
Oct 22, 2023
|
-Thanks a lot for this, you contribution to this project are so much appreciated 🙏 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
providers.kubernetesingress.ingressendpoint.publishedserviceis now set by default and will also work with custom namespace targets :)It is also now possible to deploy nginx or traefik to a namespace of your liking.
I did not change the nginx one to the default
ingress-nginxsince I don't know if changing the targetNamespace causes orphaned HelmReleases ;]This should close
#1048
#1042