Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed the default kured lock expiration as it is dangerous. #1183

Merged
merged 1 commit into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions kube.tf.example
Original file line number Diff line number Diff line change
Expand Up @@ -507,13 +507,17 @@ module "kube-hetzner" {

# If you need more control over kured and the reboot behaviour, you can pass additional options to kured.
# For example limiting reboots to certain timeframes. For all options see: https://kured.dev/docs/configuration/
# By default, the kured lock does not expire and is only released once a node successfully reboots. You can add the option
# "lock-ttl" : "30m", if you have a single node which sometimes gets stuck. Note however, that in that case, kured continuous
# draining the next node because the lock was released. You may end up with all nodes drained and your cluster completely down.
# The default options are: `--reboot-command=/usr/bin/systemctl reboot --pre-reboot-node-labels=kured=rebooting --post-reboot-node-labels=kured=done --period=5m`
# Defaults can be overridden by using the same key.
# kured_options = {
# "reboot-days": "su"
# "start-time": "3am"
# "end-time": "8am"
# "time-zone": "Local"
# "reboot-days": "su",
# "start-time": "3am",
# "end-time": "8am",
# "time-zone": "Local",
# "lock-ttl" : "30m",
# }

# Allows you to specify either stable, latest, testing or supported minor versions.
Expand Down
1 change: 0 additions & 1 deletion locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,6 @@ installCRDs: true
"pre-reboot-node-labels" : "kured=rebooting",
"post-reboot-node-labels" : "kured=done",
"period" : "5m",
"lock-ttl" : "30m"
}, var.kured_options)

k3s_registries_update_script = <<EOF
Expand Down