-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for v1.29 #1239
Support for v1.29 #1239
Conversation
@Silvest89 Could you please take care of updating the autoscaler mother repo so that our fork does not diverge 🙏 Hopefully soon enough we can go back to using that and not have to maintain our own. |
Hey @mysticaltech, I want to make sure we maintain compatibility with our 3rd party packages. The developers behind these packages are diligently working to keep up with new Kubernetes releases, which often means addressing incompatibilities/bugs or implementing new features. I collected the relevant minimum versions:
Versions after this PR:
It seems only Calico needs an upgrade. Fortunately, version 3.27 is already available. For the packages where we currently use the latest version, I would propose (maybe at some point in future) to adopt a more stringent versioning strategy to guarantee compatibility without being the first ones hitting day 1 issues of fresh releases. I prefer stability over being the early adopter (or software tester ^^). Over time, we might also face backward compatibility issues, for instance, if a package makes a major upgrade that requires a strict minimum Kubernetes version. Currently, our setup appears to install it without considering these constraints. |
@M4t7e Thanks for the info, super important indeed! Good to hear that Calico 3.27 is available, I will bump it. Definitely, same here I prefer we use stable, but this issue #1231 initially led me to believe that we needed to move to v1.19 to fix the autoscaler issue. I later learned that autoscaler v1.29.x is in fact compatible with previous versions of kube too. But what's done is done. About the autoscaler thing, what happened is that @Silvest89 contributed vital fixes and support for labelling Hetzner nodes if I remember correctly, it was merged on the mother repo kubernetes/autoscaler, but their release schedule is super long, so it just shipped a few weeks ago, in the meantime we had to fork our own (@Silvest89 did it) for users to benefit from a working version with Hetzner. Now same as before, a fix needs to be synced to the mother repo and it will take a long time to be released, so we are stuck with our own fork for a while longer. And yes, we always have the master of our fork updated from upstream via a bot. |
@mysticaltech I've already opened a PR |
Thank you @Silvest89, really appreciate it man 🙏 Please keep up posted when merged 🤞 |
Made possible by #1231 and a fix to the autoscaler by @Silvest89 🚀