Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for v1.29 #1239

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Support for v1.29 #1239

merged 3 commits into from
Feb 27, 2024

Conversation

mysticaltech
Copy link
Collaborator

Made possible by #1231 and a fix to the autoscaler by @Silvest89 🚀

@mysticaltech mysticaltech requested a review from a team February 26, 2024 21:06
aleksasiriski
aleksasiriski previously approved these changes Feb 27, 2024
variables.tf Show resolved Hide resolved
@mysticaltech
Copy link
Collaborator Author

@Silvest89 Could you please take care of updating the autoscaler mother repo so that our fork does not diverge 🙏 Hopefully soon enough we can go back to using that and not have to maintain our own.

@mysticaltech mysticaltech merged commit 31d7594 into master Feb 27, 2024
3 checks passed
@mysticaltech mysticaltech deleted the upgrade/kube-and-autoscaler branch February 27, 2024 19:53
@M4t7e
Copy link
Contributor

M4t7e commented Feb 27, 2024

Hey @mysticaltech, I want to make sure we maintain compatibility with our 3rd party packages. The developers behind these packages are diligently working to keep up with new Kubernetes releases, which often means addressing incompatibilities/bugs or implementing new features.

I collected the relevant minimum versions:

K3s Autoscaler Calico Cilium HCCM HCSI Kured
1.26 1.26 3.25 1.13 1.14 2.2 1.12
1.27 1.27 3.26 1.14 1.16 2.4 1.13
1.28 1.28 3.25 1.15 1.18 2.5 1.14
1.29 1.29 3.27 1.15 1.19 2.6 1.15

Versions after this PR:

  • Autoscaler: 20240226 -> 1.29 (OK)
  • Calico: 3.26.4 (Not OK)
  • Cilium: 1.15.1 (OK)
  • HCCM: latest (OK)
  • HCSI: latest (OK)
  • Kured: latest (OK)

It seems only Calico needs an upgrade. Fortunately, version 3.27 is already available.
I'm a bit confused about our Autoscaler versioning, but I understood this version reflects 1.29.

For the packages where we currently use the latest version, I would propose (maybe at some point in future) to adopt a more stringent versioning strategy to guarantee compatibility without being the first ones hitting day 1 issues of fresh releases. I prefer stability over being the early adopter (or software tester ^^). Over time, we might also face backward compatibility issues, for instance, if a package makes a major upgrade that requires a strict minimum Kubernetes version. Currently, our setup appears to install it without considering these constraints.

@mysticaltech
Copy link
Collaborator Author

@M4t7e Thanks for the info, super important indeed! Good to hear that Calico 3.27 is available, I will bump it.

Definitely, same here I prefer we use stable, but this issue #1231 initially led me to believe that we needed to move to v1.19 to fix the autoscaler issue. I later learned that autoscaler v1.29.x is in fact compatible with previous versions of kube too. But what's done is done.

About the autoscaler thing, what happened is that @Silvest89 contributed vital fixes and support for labelling Hetzner nodes if I remember correctly, it was merged on the mother repo kubernetes/autoscaler, but their release schedule is super long, so it just shipped a few weeks ago, in the meantime we had to fork our own (@Silvest89 did it) for users to benefit from a working version with Hetzner. Now same as before, a fix needs to be synced to the mother repo and it will take a long time to be released, so we are stuck with our own fork for a while longer. And yes, we always have the master of our fork updated from upstream via a bot.

@Silvest89
Copy link
Contributor

@mysticaltech I've already opened a PR

@mysticaltech
Copy link
Collaborator Author

Thank you @Silvest89, really appreciate it man 🙏 Please keep up posted when merged 🤞

@mysticaltech mysticaltech mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants