Fix LoadBalancer service using both public and private IP of LB's #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tzner LB When a new service of type LoadBalancer is requested k3s will use besides the public IPv4 & 6 of the Hetzner LB also the private ip of that LB which is wrong. This also fixes the external-dns updating A records with the private IP of the LB
mysticaltech
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new service of type LoadBalancer is requested k3s will use besides the public IPv4 & 6 of the Hetzner LB also the private ip of that LB which is wrong.
This also fixes the external-dns updating A records with the private IP of the LB
With
HCLOUD_LOAD_BALANCERS_DISABLE_PRIVATE_INGRESS: true( this is the default value )external-dns will detect external load balancer IP's and will create following A records: ( cloudflare, but with other dns providers will be the same issue )
With this new change:
With
HCLOUD_LOAD_BALANCERS_DISABLE_PRIVATE_INGRESS: falseWith this new change external dns won't create the A record for the private iP