Set default lb location to hcloud ccm #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use loadbalancer_localtion as value
oujonny
force-pushed
the
feat/ccm_default_lb_location
branch
from
84dc014
to
579e5f0
Compare
|
Thanks, @oujonny, it looks good to me! Did you test it? Let me know; if it deploys fine on your side, I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR sets these two environments variables to the hcloud ccm. The settings are the same as for the treafik lb, but this way they are default values for the hole cluster.
More informations about these env here: https://github.com/hetznercloud/hcloud-cloud-controller-manager/blob/main/docs/load_balancers.md
It is related to #175 .