Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates #30

Closed
wants to merge 2 commits into from
Closed

Readme updates #30

wants to merge 2 commits into from

Conversation

phaer
Copy link
Contributor

@phaer phaer commented Jan 25, 2022

Hi again,

This will be my last PR for now, I promise ;)

This contains slightly adapted backup & debugging sections from https://github.com/StarpTech/k-andy/blob/main/README.md because I found them useful and thought others might profit from that info as well.

It also adds myself to contributors, if that's okay? Feel free to selectively merge the other commit otherwise

@mysticaltech
Copy link
Collaborator

The logic here changes from k-andy, because I'm using k3os, all this extra part does not apply 100%, will not merge for now. But I will add your name myself right away! Thanks for your awesome contributions! Keep the PR coming, please! 🙏

@phaer
Copy link
Contributor Author

phaer commented Jan 25, 2022

Oh well, thanks for catching that! I actually verified the reset procedure, but ran k3s manually at that time and so I guess the difference is mostly with the systemctl usage? Sorry for the noise, might verify & update instructions in the future.

@mysticaltech
Copy link
Collaborator

mysticaltech commented Jan 25, 2022

Ok, good to know! Sorry, I had assumed you did not test the commands mentioned, my bad! However, I would also like the Readme to stay as simple as possible.

What we could do in the future definitely, is create other linked MD files, one for that, and another one to share SSL termination for instance (like discussed in issues #18 and #24).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants