Fix/invert loadbalancer label on control planes #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, the label exclude-from-external-load-balancers is set to true on control planes even if allow_scheduling_on_control_plane is set to true in the kube.tf file.
|
@mattanja Thanks for noticing, I will investigate and test your changes. |
|
@mattanja Your fix was accurate! Thanks for this. It's been released in 1.10.6 🙏🚀 If you still do not see the control plane as target list, please try to see if there are any remaining NoSchedule taints on those. Normally there should not be when allow_scheduling_on_control_planes is set to true! Let me know, and don't hesitate to open an issue to investigate this deeper, or provide an additional fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I can't find the "staging" branch mentioned in the contribution section of the readme, so I'm targeting master for now?
I've had the issue of the label
node.kubernetes.io/exclude-from-external-load-balancersbeing set to true withallow_scheduling_on_control_plane=truein my configuration. After searching for the issue it seem to me that the conditions are not being set correctly.There are two separate concerns mixed: the loadbalancer targeting the control planes (set via an "exclude" meaning inverted label) and the scheduling of load on the control planes (set via the ":NoSchedule" taint).
The condition for the loadbalancer label seems to have been inverted. (I'm not sure how it would have been possible that this was not detected before, which makes me doubt my solution.)
I have now tested the cluster setup with 3 control planes with
allow_scheduling_on_control_plane=trueand the label was set tonode.kubernetes.io/exclude-from-external-load-balancers: "false"which should be correct. However, the LoadBalancer still did not target the servers. Maybe there are additional issues?