Update variables.tf #689
Merged
Update variables.tf #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently k8s only support 3 entries for DNS servers. To avoid these warning "Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: 8.8.8.8 8.8.4.4 1.1.1.1"
|
@Wuppie007 Thanks for this. Please don't hesitate to tweak the If you are feeling adventurous, see how validations are done for some other variables (or just use chatgpt 4 🤐) to add a validation for 3 max values, it's just another attribute in the variable object. |
Added validation for DNS list length
|
I would argue to use both cloudflare's DNS servers and one Google, or even Quad9 as the third instead of Google |
Updated DNS servers to three different DNS servers: Google, Cloudflare and quad9
|
Updated now for three different companies: ["8.8.8.8","1.1.1.1","9.9.9.9"] |
|
Released in v2.0.2, thanks for your contribution both. FYI, I finally opted for @aleksasiriski's recommendation to put Cloudflare first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently k8s only support 3 entries for DNS servers.
Check the validation here: https://github.com/kubernetes/kubernetes/blob/c970a46bc1bcc100bbbfabd5c12bd4c5d87f8aea/pkg/apis/core/validation/validation.go#L2944-L2953
To avoid these warning "Nameserver limits were exceeded, some nameservers have been omitted, the applied nameserver line is: 8.8.8.8 8.8.4.4 1.1.1.1"
randomly removed the last entry ;)