Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add k3s ver to null resource kustomization #706

Merged
merged 1 commit into from
Apr 10, 2023
Merged

add k3s ver to null resource kustomization #706

merged 1 commit into from
Apr 10, 2023

Conversation

aleksasiriski
Copy link
Member

terraform apply now updates the k3s ver without errors

I just had a question: is it possible to have a channel for cluster autoscaler as well? So we aren't fixated on a patch version but instead always pull latest?

@mysticaltech
Copy link
Collaborator

mysticaltech commented Apr 9, 2023

@aleksasiriski Good to see this works!

About the cluster autoscaler, I have been thinking about this too. The problem is that it does not have "channels", but instead like you say, we could just remove the tag so that it fetches the latest and greatest (by default, allowing people to set a version if they want to). I think this would work great!

@mysticaltech mysticaltech merged commit cc4459e into kube-hetzner:staging Apr 10, 2023
1 check passed
@mysticaltech
Copy link
Collaborator

mysticaltech commented Apr 10, 2023

I tried without the autoscaler version tag, it doesn't work. I guess we will have to change to helm to fix the autoscaler version thing, because the version is set by default in the default helm values.yaml.

@nikolaszimmermann
Copy link
Contributor

NOTE: I'm closely tracking upstream progress, and would wish for more helpful commit messages -- I can deduce that the k3s version was added to versions field of the kustomizaton null_resource from the commit, the intersting part: why? is only answered here, and not in the commit message.

No criticisim, just asking to make my downstream life easier :-)

@aleksasiriski
Copy link
Member Author

NOTE: I'm closely tracking upstream progress, and would wish for more helpful commit messages -- I can deduce that the k3s version was added to versions field of the kustomizaton null_resource from the commit, the intersting part: why? is only answered here, and not in the commit message.

No criticisim, just asking to make my downstream life easier :-)

I was lazy, will have to change that habit. Noted.

@mysticaltech
Copy link
Collaborator

Great tip @nikolaszimmermann! We will improve.

@aleksasiriski FYI https://github.com/Nutlope/aicommits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants