Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation to use TLS with traefik #85

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

owngr
Copy link
Contributor

@owngr owngr commented Feb 20, 2022

Here's the tested documentation to quickly spin up an nginx pod with TLS, as asked here #37 (comment)

I'm just not sure about the subdomains part, I usually use one certificate per subdomain,

@mysticaltech
Copy link
Collaborator

I love the idea of an examples directory. Thanks for that @Olivierwenger!

@phaer and @mnencia, I propose we merge this without further do, what do you say?

@phaer
Copy link
Contributor

phaer commented Feb 20, 2022

Looks good to me, I think there's more to be done regarding more structured examples in the future, but it's a good start
One suggestion: I would prefer examples instead of .examples in this case. Using hidden directories might make sense for the images, but examples should be discoverable so there's no benefit in hiding them on *nix systems in my opionion.

Thanks, @Olivierwenger!

@TimHeckel
Copy link
Contributor

TimHeckel commented Feb 20, 2022

@Olivierwenger - thank you for documenting this!

@mysticaltech
Copy link
Collaborator

Thanks folks! @Olivierwenger if you can change from . examples to examples it would be great, then we'll merge! 🙏

@phaer phaer merged commit 06fbc40 into kube-hetzner:master Feb 21, 2022
@phaer
Copy link
Contributor

phaer commented Feb 21, 2022

@Olivierwenger Thanks!

@owngr
Copy link
Contributor Author

owngr commented Feb 21, 2022

@phaer thanks to you for being so quick :)

@owngr owngr deleted the feature/tls-documentation branch February 25, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants