-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fuentbit): update PSP resource with missing values #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
force-pushed
the
aslafy-z-patch-3
branch
from
January 17, 2023 17:57
fa44c44
to
e9e23d1
Compare
siliconbrain
requested changes
Jan 18, 2023
siliconbrain
requested changes
Jan 18, 2023
siliconbrain
previously approved these changes
Jan 18, 2023
Co-authored-by: Dudás Ádám <adudas@cisco.com>
Co-authored-by: Dudás Ádám <adudas@cisco.com>
aslafy-z
force-pushed
the
aslafy-z-patch-3
branch
from
February 22, 2023 10:48
36c07cd
to
7615519
Compare
siliconbrain
approved these changes
Feb 22, 2023
ahma
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Update the Fluentbit PSP with missing hostpaths, hostports and hostnetwork.
Why?
Logging operator cannot be deployed on GKE with the current default.
Checklist