Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssl version in opensearch #1330

Merged
merged 4 commits into from
May 18, 2023

Conversation

joseacl
Copy link
Contributor

@joseacl joseacl commented May 12, 2023

Fixes #1088 together with kube-logging/helm-charts#22.

@joseacl joseacl force-pushed the ssl_version_opensearch branch 3 times, most recently from f95f0fd to db87fb7 Compare May 16, 2023 14:01
@joseacl
Copy link
Contributor Author

joseacl commented May 16, 2023

Hi @pepov I've just done a rebase from master, but looks like the merge commit in master (596ac6b) was not signed, and that (I think) is the reason of the DCO failing here.

@pepov
Copy link
Member

pepov commented May 16, 2023

@joseacl it says:

Commit sha: bf04ff2, Author: Jose Antonio Cortes Lopez, Committer: José Antonio Cortés López; Expected "Jose Antonio Cortes Lopez jacortes@theworkshop.com", but got "joseacl joseacl@gmail.com".

Signed-off-by: joseacl <joseacl@gmail.com>
Signed-off-by: joseacl <joseacl@gmail.com>
@joseacl
Copy link
Contributor Author

joseacl commented May 16, 2023

@joseacl it says:

Commit sha: bf04ff2, Author: Jose Antonio Cortes Lopez, Committer: José Antonio Cortés López; Expected "Jose Antonio Cortes Lopez jacortes@theworkshop.com", but got "joseacl joseacl@gmail.com".

You're right, sorry it was my fault. Already fixed, thanks!

Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you please bump the logging operator chart's minor version?

Signed-off-by: joseacl <joseacl@gmail.com>
@joseacl
Copy link
Contributor Author

joseacl commented May 17, 2023

would you please bump the logging operator chart's minor version?

Also done kube-logging/helm-charts@c206fc3

@joseacl joseacl requested a review from pepov May 17, 2023 12:05
@pepov
Copy link
Member

pepov commented May 18, 2023

this a temporary ugliness, but the chart should be in sync with kube-logging/helm-charts so please bump the chart version here as well

Signed-off-by: joseacl <joseacl@gmail.com>
@pepov pepov merged commit 6931c39 into kube-logging:master May 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssl_version is not working for Opensearch Outputs
2 participants