feat(charts,logging-operator): make configCheck configurable in loggi… #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiangaiser
force-pushed
the
feature/logging-configCheck
branch
from
e083ff4
to
463e579
Compare
|
@pepov can you please guide me a bit if a version change is needed in the |
…ng resource Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
sebastiangaiser
force-pushed
the
feature/logging-configCheck
branch
from
463e579
to
099ab04
Compare
|
@sebastiangaiser you don't need other than a release, which will automatically set the chart version as part of the workflow |
pepov
approved these changes
Feb 26, 2024
|
Ok, shall I update/rebase my branch from main? |
|
not necessary for this |
OverOrion
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng resource
I ran into #1377 and would like to give it a try.