Allow ClusterOutput and ClusterFlow resources defined in arbitrary namespaces #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepov
changed the title
pepov
force-pushed
the
cluster-resource-ns-arbitrary
branch
from
21d00b3
to
60dedd9
Compare
pepov
force-pushed
the
cluster-resource-ns-arbitrary
branch
from
32a6c19
to
7fa4f18
Compare
tarokkk
approved these changes
Jun 15, 2020
ahma
approved these changes
Jun 15, 2020
siliconbrain
approved these changes
Jun 15, 2020
| @@ -263,8 +263,14 @@ func (r *LoggingReconciler) GetResources(logging *loggingv1beta1.Logging) (*mode | |||
| loggingResources := model.NewLoggingResources(logging, r.Client, r.Log) | |||
| var err error | |||
|
|
|||
| listOptsForClusterResources := []client.ListOption{} | |||
There was a problem hiding this comment.
Suggested change
| listOptsForClusterResources := []client.ListOption{} | |
| var listOptsForClusterResources []client.ListOption |
Could save an unnecessary allocation.
simonkey007
pushed a commit
to simonkey007/logging-operator
that referenced
this pull request
Mar 11, 2021
EppO
pushed a commit
to EppO/logging-operator
that referenced
this pull request
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds an optional, backwards compatible flag to allow using
ClusterOutputandClusterFlowresources in arbitrary namespaces. Administrators will still be able to control who has the ability to create such resources through RBAC.Why?
To support use cases where a development team has ownership over logs coming from multiple namespaces but they can only deploy resources into their own namespace and cannot access the logging's control namespace.