[WIP] add elasticsearch output #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wwojcik
force-pushed
the
feature/elasticsearch-output
branch
3 times, most recently
from
3e518bb
to
00431de
Compare
wwojcik
force-pushed
the
feature/elasticsearch-output
branch
from
00431de
to
e31867c
Compare
tarokkk
requested changes
Mar 9, 2019
There was a problem hiding this comment.
Thank you for the contribution. It works for me on local as well. The only suggestion is to move these hardcoded parameters to values. And remove the [WIP] tag when you feel ready.
retry_type exponential_backoff
flush_thread_count 2
flush_interval 5s
retry_forever
retry_max_interval 30
tarokkk
approved these changes
Mar 9, 2019
|
After weekend it's will ready sorry |
|
Hello @wwojcik, what about add "user" and "password" fields to fluentd's configuration template? Of course default values also should be provided (nil) https://docs.fluentd.org/v1.0/articles/out_elasticsearch#user,-password-(optional) |
simonkey007
pushed a commit
to simonkey007/logging-operator
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add support elasticsearch outpout