fixed bug in generateBucketName #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the prefix length is exactly maxBaseNameLen, the prefix is not truncated and as a result the generated bucket name is invalid Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
|
This looks good to me, but please clarify in the commit what exactly is making the generated name invalid. Is the generated name too long? Or is it an issue of not allowing multiple consecutive dashes? It's not fully clear to me. |
|
I did confirm that this patch fixes the issue in Rook upstream, and I do believe this is length-related. |
BlaineEXE
added a commit
to BlaineEXE/rook
that referenced
this pull request
Jan 5, 2022
The latest lib-bucket-provisioner has a corner case fix for a bucket with `generateName` equal to exactly 27 chars, which will result in an ObjectBucket with 64 chars. 63 chars is the max allowed by Kubernetes. See: kube-object-storage/lib-bucket-provisioner#220 Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
10 tasks
mergify bot
pushed a commit
to rook/rook
that referenced
this pull request
Jan 5, 2022
The latest lib-bucket-provisioner has a corner case fix for a bucket with `generateName` equal to exactly 27 chars, which will result in an ObjectBucket with 64 chars. 63 chars is the max allowed by Kubernetes. See: kube-object-storage/lib-bucket-provisioner#220 Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com> (cherry picked from commit ae306e4)
parth-gr
pushed a commit
to parth-gr/rook
that referenced
this pull request
Feb 22, 2022
The latest lib-bucket-provisioner has a corner case fix for a bucket with `generateName` equal to exactly 27 chars, which will result in an ObjectBucket with 64 chars. 63 chars is the max allowed by Kubernetes. See: kube-object-storage/lib-bucket-provisioner#220 Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
parth-gr
pushed a commit
to parth-gr/rook
that referenced
this pull request
Feb 22, 2022
The latest lib-bucket-provisioner has a corner case fix for a bucket with `generateName` equal to exactly 27 chars, which will result in an ObjectBucket with 64 chars. 63 chars is the max allowed by Kubernetes. See: kube-object-storage/lib-bucket-provisioner#220 Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the prefix length is exactly maxBaseNameLen, the prefix is not truncated and as a result, the generated bucket name is invalid.
Signed-off-by: Danny Zaken dannyzaken@gmail.com