[release-4.7] Bug 1929042: Avoid requeueing an expired Report #1505
Conversation
Update the Report handler and avoid requeueing a Report that is reporting an `expired `status. Before, this would result in the reporting-operator hot looping as this Report custom resource would continue to get queued up. Instead if we're encountering a Report that has reached it's expiration date, then we should avoid processing it in the Report handler function and let the call site determine how to process that Report further in the next cycle.
|
@openshift-cherrypick-robot: Bugzilla bug 1926984 has been cloned as Bugzilla bug 1929042. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1929042, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
bugzilla/valid-bug
|
/approve |
|
@timflannagan: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Note: this will need to be shipped in a 4.7 z-stream release. |
ecordell
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1929042 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@timflannagan: new pull request created: #1521 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1476
/assign timflannagan