Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard Condition definitions and add a Default derive #30

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Use standard Condition definitions and add a Default derive #30

merged 4 commits into from
Apr 30, 2024

Commits on Apr 24, 2024

  1. use standard Condition definitions from k8s-openapi 

    Regenrate the definitions with kopium v0.17.2 to get rid of the custom
Condition definitions generated for each API and use a standard
definition from the k8s-openapi crate instead.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
    @aryan9600
    aryan9600 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    943e0ee View commit details
    Browse the repository at this point in the history

  2. add codegen tool to generate Default impls for enums 

    Add a codegen tool `enum_default_generator` that reads enum names along
with their default variants from the enviornment and then generates
implementations of the Default trait for them.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
    @aryan9600
    aryan9600 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a669795 View commit details
    Browse the repository at this point in the history

  3. derive the Default trait for all APIs 

    Modify `update.sh` to generate APIs which derive the `Default` trait:

* Update the kopium command in `update.sh` so that all APIs auto-derive
  the Default trait.
* Use the enum default generator tool to generate `Default` trait impls
  for all Gateway API enums.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
    @aryan9600
    aryan9600 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a77cbc0 View commit details
    Browse the repository at this point in the history

  4. refactor enum default generator as an xtask 

    Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
    @aryan9600
    aryan9600 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c97c721 View commit details
    Browse the repository at this point in the history