Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic for invalid field name #166

Closed
sebhoss opened this issue Nov 4, 2023 · 1 comment · Fixed by #167
Closed

panic for invalid field name #166

sebhoss opened this issue Nov 4, 2023 · 1 comment · Fixed by #167
Labels
bug Something isn't working

Comments

@sebhoss
Copy link
Contributor

sebhoss commented Nov 4, 2023

https://github.com/VictoriaMetrics/operator/blob/master/config/crd/bases/operator.victoriametrics.com_vmagents.yaml#L47 has a field name called - which causes kopium to panic. Stacktrace:

RUST_BACKTRACE=full kopium --docs --filename ./crd-catalog/VictoriaMetrics/operator/operator.victoriametrics.com/v1beta1/vmagents.yaml
// WARNING: generated by kopium - manual changes will be overwritten
// kopium command: kopium --docs --filename ./crd-catalog/VictoriaMetrics/operator/operator.victoriametrics.com/v1beta1/vmagents.yaml
// kopium version: 0.16.1

thread 'main' panicked at src/output.rs:99:40:
invalid field name '-' could not be escaped
stack backtrace:
   0:     0x561eeeef8e6c - <unknown>
   1:     0x561eeef27bfc - <unknown>
   2:     0x561eeeef545e - <unknown>
   3:     0x561eeeef8c54 - <unknown>
   4:     0x561eeeefab93 - <unknown>
   5:     0x561eeeefa8ac - <unknown>
   6:     0x561eeeefb119 - <unknown>
   7:     0x561eeeefb017 - <unknown>
   8:     0x561eeeef9396 - <unknown>
   9:     0x561eeeefad62 - <unknown>
  10:     0x561eeea8c793 - <unknown>
  11:     0x561eeee4d148 - <unknown>
  12:     0x561eeee4d790 - <unknown>
  13:     0x561eeead34c8 - <unknown>
  14:     0x561eeeacfb38 - <unknown>
  15:     0x561eeeb3348f - <unknown>
  16:     0x561eeeb03bd3 - <unknown>
  17:     0x561eeeb3c40d - <unknown>
  18:     0x561eeeeee60b - <unknown>
  19:     0x561eeeb336d5 - <unknown>
  20:     0x7fa2ca9ceb8a - __libc_start_call_main
  21:     0x7fa2ca9cec4b - __libc_start_main_alias_2
  22:     0x561eeea8ce1e - <unknown>
  23:                0x0 - <unknown>
clux added a commit that referenced this issue Nov 4, 2023
fixes #166

Signed-off-by: clux <sszynrae@gmail.com>
@clux
Copy link
Member

clux commented Nov 4, 2023

Thanks for the report with an easy repro. A fix can be found in #167 - will likely release that next week modulo reviews.

@clux clux added the bug Something isn't working label Nov 4, 2023
@clux clux closed this as completed in #167 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants