Fixes clippy lints

[Dav1dde]

Fixes clippy lints (except tests) and adds clippy to CI

[clux]

looks good!

[Dav1dde]

looks good!

That was fast :D

Added the cache action for clippy as well, since it fetches the cargo index before running

[clux]

cache action

Yeah, that's helpful. This repo is less professional than kube and could do with some more of this stuff :-)

[Dav1dde]

You're using the clippy action in kube:

      - uses: actions-rs/clippy-check@v1
        with:
          args: "--workspace"
          token: ${{ secrets.GITHUB_TOKEN }}

Want me to change it here as well? I checked it out before but it looked like it does not work properly for pull requests, but I might be misunderstanding the issue.

[clux]

I honestly don't remember what the token is for, but it seems to be required and the action is really nice, and we've not had any problems with it AFAIK. Getting the lints inlined into the PR makes them easy to identify when they are created.

[Dav1dde]

Updated:

Error: Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration
Warning: It seems that this Action is executed from the forked repository.
Warning: GitHub Actions are not allowed to create Check annotations, when executed for a forked repos. See https://github.com/actions-rs/clippy-check/issues/2 for details.
Posting clippy checks here instead.

Not sure what that means, but clippy is still executed, so even in the case the action fails clippy runs which is all we need.

[clux]

Ah, I guess it only (fully) works (to create inline annotations) if you create a PR from a branch against kube-rs origin. This should work for you since you, but not many others.

[clux]

Let's try it out :-)