Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes skipped types if nested in array #113

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fixes skipped types if nested in array #113

merged 1 commit into from
Feb 16, 2023

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Feb 16, 2023 •
edited

fixes: #110

This works for my usecase, but I am not quite sure if it fixes all problems.

clux
clux approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great. perfect part to factor out really if it helps.
i suspect this can actually fix a lot of things because we had lots of issues with maps.

might be worth checking the state of some of the bugs after this :-)

src/analyzer.rs Show resolved Hide resolved
src/analyzer.rs Outdated Show resolved Hide resolved
@Dav1dde
fixes skipped types if nested in array
3850efe 
fixes: #110

Signed-off-by: David Herberth <github@dav1d.de>
@Dav1dde Dav1dde merged commit cdff486 into main Feb 16, 2023
@Dav1dde Dav1dde deleted the missing-map-types branch February 16, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kopium skips generating types which are then not referencable
2 participants
@Dav1dde @clux