conditionally render status line #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
approved these changes
Mar 16, 2024
sebhoss
force-pushed
the
istio-status-support
branch
2 times, most recently
from
c777f10
to
c961145
Compare
Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
sebhoss
force-pushed
the
istio-status-support
branch
from
c961145
to
3c348cc
Compare
clux
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to get the Istio resources working which do not specify their
statusfields but rather usex-kubernetes-preserve-unknown-fields. Currently kopium does not generate aXyzStatusstruct for that but still adds a#[kube(status = "XyzStatus")]line to thespecstruct which causes compile errors. This PR changes that so that the status line is only added if we have an actual status container and that container has members. In every other case, kopium does not generate a status struct and uses a BTreeMap instead which cannot be used in the#[kube(status = ...)]line.I'm not entirely sure if this breaks anything else down the line, however I was able to generate &
cargo checkevery custom resource in metio/kube-custom-resources-rs#222 with this change.