Add relaxed mode for partially invalid CRDs #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes kube-rs#108 Argo workflows have 2 CRDs, minimal and full. The full CRD is supposed to be used in the editor and can't be installed in kubernetes, but provide full validation. The minimal version has no validation and should be installed. In `--relaxed` mode, entries like `inline: {}` are mapped to object like hashmaps. Signed-off-by: Daniel Poelzleithner <poelzleithner@b1-systems.de>
poelzi
force-pushed
the
fix-argo-workflows
branch
from
f243151
to
e26da69
Compare
|
Hey, thanks a lot for this. I think the strategy chosen here makes complete sense given that it's a place we already I see tests are difficult to do in the integration setting, but I have one simpler suggestion, if you are able; you could try to extract a unit test (in the style of the ones found in analyzer.rs) on one of these emptier blocks in the schema (we test subsections of the schemas), and we can verify that the output you produce in the new fallback actually happens. |
clux
reviewed
Mar 21, 2024
Signed-off-by: Eirik A <sszynrae@gmail.com>
clux
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108
Argo workflows have 2 CRDs, minimal and full.
The full CRD is supposed to be used in the editor and can't be installed in kubernetes, but provide full validation. The minimal version has no validation and should be installed.
In
--relaxedmode, entries likeinline: {}are mapped to object like hashmaps, empty arrays are ignored.You can't use the normal tests because the crds are not installable.