Added btreemap flag to toggle BTreeMap/HashMap for map types
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrone-wu
force-pushed
the
btreemap-flag
branch
from
70104b9
to
a7091fd
Compare
Added boolean flag `btreemap` that toggles whether to to use BTreeMap or HashMap for representing map/additional_properties type. Fixes: kube-rs#78 Signed-off-by: tyrone-wu <wudevelops@gmail.com>
tyrone-wu
force-pushed
the
btreemap-flag
branch
from
a7091fd
to
b569dee
Compare
Signed-off-by: Eirik A <sszynrae@gmail.com>
|
hey, thanks for this! I have one self-doubt here about changing the default (since it's been so long and the more i think about it BTreeMap is a good default), but the implementation here is a great jumping off point! i might change it to an enum'd var in main and keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 馃憢 Nice name project name! 馃槃 Here's my stab at #78.
Added boolean flag
btreemapthat toggles whether to to use BTreeMap or HashMap for representing map/additional_properties type.Fixes: #78