Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor away rightward drift in main #233

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Refactor away rightward drift in main #233

merged 1 commit into from
Apr 30, 2024

Conversation

clux
Copy link
Member

@clux clux commented Apr 29, 2024

Using

  1. let else instead of big indent + else at the bottom
  2. returning error early
  3. continue early

then 2 more minor tweaks: crd iterations common var + use Vec<&str> for less to_string gunk

Using
1. let else instead of big indent + else at the bottom
2. returning error early
3. continue early

another minor tweak in crd iterations for less code

Signed-off-by: clux <sszynrae@gmail.com>
Copy link
Member Author

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

highlighting what caused de-indents. no other changes in that main loop in generate apart from the two pointed out causing double deindent. although this is easier to review if you check the "ignore indent" thing.

src/main.rs Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
@clux clux marked this pull request as ready for review April 29, 2024 21:11
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@clux clux merged commit bde73a4 into main Apr 30, 2024
6 checks passed
@clux clux deleted the refactor-out-rightward branch April 30, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants