Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a doc example to Controller::watches #1016

Closed
clux opened this issue Sep 20, 2022 · 0 comments · Fixed by #1026
Closed

Add a doc example to Controller::watches #1016

clux opened this issue Sep 20, 2022 · 0 comments · Fixed by #1026
Labels
docs unclear documentation help wanted Not immediately prioritised, please help!

Comments

@clux
Copy link
Member

clux commented Sep 20, 2022 •
edited

Show how to cobble together a relation mapper using the same annotations that operator-sdk uses

There is a rudimentary example for this in https://kube.rs/controllers/relations/#watched-relations, but we currently have no compiled doctest for it.

Location to add:
https://github.com/kube-rs/kube-rs/blob/cc2a2b9a9fa27167f988474d14a925cb8a96afc8/kube-runtime/src/controller/mod.rs#L584-L610
@clux clux added the docs unclear documentation label Sep 20, 2022
@clux clux changed the title Add an example to Controller::watches Add a doc example to Controller::watches Sep 20, 2022
@clux clux added the help wanted Not immediately prioritised, please help! label Sep 20, 2022
Dav1dde added a commit to Dav1dde/kube that referenced this issue Sep 25, 2022
@Dav1dde
Adds example to Controler::watches
01232f7 
Closes kube-rs#1016
@Dav1dde Dav1dde mentioned this issue Sep 25, 2022
Merged
Dav1dde added a commit to Dav1dde/kube that referenced this issue Sep 25, 2022
@Dav1dde
Adds example to Controller::watches
3e3bc01 
Closes kube-rs#1016
Dav1dde added a commit to Dav1dde/kube that referenced this issue Sep 25, 2022
@Dav1dde
Adds example to Controller::watches
799b990 
Closes kube-rs#1016

Signed-off-by: David Herberth <github@dav1d.de>
Dav1dde added a commit to Dav1dde/kube that referenced this issue Sep 27, 2022
@Dav1dde
Adds example to Controller::watches
116f6fa 
Closes kube-rs#1016

Signed-off-by: David Herberth <github@dav1d.de>
Dav1dde added a commit to Dav1dde/kube that referenced this issue Sep 27, 2022
@Dav1dde
Adds example to Controller::watches
138c797 
Closes kube-rs#1016

Signed-off-by: David Herberth <github@dav1d.de>
Dav1dde added a commit to Dav1dde/kube that referenced this issue Sep 27, 2022
@Dav1dde
Adds example to Controller::watches
ce4cc24 
Closes kube-rs#1016

Signed-off-by: David Herberth <github@dav1d.de>
clux pushed a commit that referenced this issue Sep 27, 2022
@Dav1dde
Adds example to Controller::watches (#1026)
58e5cdf 
Closes #1016

Signed-off-by: David Herberth <github@dav1d.de>

Signed-off-by: David Herberth <github@dav1d.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs unclear documentation help wanted Not immediately prioritised, please help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds example to Controller::watches Dav1dde/kube
1 participant
@clux