Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The kube-runtime watcher::Config is missing basic traits #1205

Closed
maltesander opened this issue Apr 19, 2023 · 2 comments · Fixed by #1206
Closed

The kube-runtime watcher::Config is missing basic traits #1205

maltesander opened this issue Apr 19, 2023 · 2 comments · Fixed by #1206
Labels
bug Something isn't working

Comments

@maltesander
Copy link

Current and expected behavior

Release 0.81.0 states:
If you were passing ListParams to watcher or Controller, you can change this for a new watcher::Config with a mostly compatible interface [...]

I wanted to update to 0.82.1 (from 0.78.0) and replace some of our ListParams with watcher::Config. These are cloned from time to time but the derives for that are currently missing (see https://github.com/kube-rs/kube/blob/main/kube-runtime/src/watcher.rs#L184).

This is not a bug but having a Clone or Debug would be convenient.

Possible solution

Add basic derives like e.g.
#[derive(Clone, Debug)]

Additional context

No response

Environment

Not required

Configuration and features

k8s-openapi = { version = "0.18.0", default-features = false, features = ["schemars", "v1_26"] }
kube = { version = "0.82.1", features = ["jsonpatch", "runtime", "derive"] }

Affected crates

kube-runtime

Would you like to work on fixing this bug?

maybe

@maltesander maltesander added the bug Something isn't working label Apr 19, 2023
@clux
Copy link
Member

clux commented Apr 19, 2023

Ugh, yep. you are right. Thank you.
I was going to do a bugfix release today anyway, will aim to get this in.

@maltesander
Copy link
Author

Thank you this was fast :)

clux added a commit that referenced this issue Apr 19, 2023
fixes #1205

Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants