Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better codegen for custom resources #159

Closed
clux opened this issue Mar 1, 2020 · 3 comments
Closed

better codegen for custom resources #159

clux opened this issue Mar 1, 2020 · 3 comments
Labels
api Api abstraction related derive kube-derive proc_macro related
Milestone
kubecon-eu-2020

Comments

@clux
Copy link
Member

clux commented Mar 1, 2020

Currently there's a regression on using .status objects in master due to #157 . In particular reasons highlighted in #157 (comment)
@clux clux added the api Api abstraction related label Mar 1, 2020
@clux
Copy link
Member Author

clux commented Mar 1, 2020

Thinking we should maybe make a smaller, and more targeted derive crate. The one we currently use (that doesn't do all we need, plus a bunch of api feature related stuff in k8s_openapi), and also pulls in like 10 deps. Not sure if this is particularly hard or not, but need to improve the CRD case again before a full release.

@clux clux added this to the kubecon-eu-2020 milestone Mar 1, 2020
@clux clux mentioned this issue Mar 1, 2020
Closed
clux added a commit that referenced this issue Mar 1, 2020
@clux
move to workspaces - for #159
9174f69 
to avoid future pr clashes
@clux
Copy link
Member Author

clux commented Mar 1, 2020

Have lifted the folder up into a kube subfolder so we can codegen.

clux added a commit that referenced this issue Mar 1, 2020
@clux
failing tests for kube-derive - for #159
f47acd1 
ripped out everything but arg parsing from the original
k8s-openapi-derive crate. Do not need the swagger validation at the
moment, but would like a more kubebuilder like setup (but typesafe).
@clux clux mentioned this issue Mar 1, 2020
Merged
@clux
Copy link
Member Author

clux commented Mar 5, 2020

Implemented in 0.28.0. See examples with crd_ prefix.

@clux clux closed this as completed Mar 5, 2020
@clux clux added the derive kube-derive proc_macro related label Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Api abstraction related derive kube-derive proc_macro related
Projects
None yet
Milestone
kubecon-eu-2020
Development

No branches or pull requests
1 participant
@clux