Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api::replace can fail to unset list values with k8s-openapi 0.12 #581

Closed
clux opened this issue Jul 5, 2021 · 1 comment
Closed

Api::replace can fail to unset list values with k8s-openapi 0.12 #581

clux opened this issue Jul 5, 2021 · 1 comment
Labels
api Api abstraction related bug Something isn't working critical issues that will be added to release notes

Comments

@clux
Copy link
Member

clux commented Jul 5, 2021

The Option removal change had some unfortunate consequences.
See Arnavion/k8s-openapi#103
Keeping this as a tracking issue in here, because we are still doing some releases.

You probably won't notice this if you are using small patches in your mutations, but be aware that you might not be able to unset certain values with Api::replace
@clux clux added bug Something isn't working api Api abstraction related labels Jul 5, 2021
@clux clux mentioned this issue Aug 3, 2021
Closed
@clux
Copy link
Member Author

clux commented Aug 3, 2021

This has been reverted in k8s-openapi master.

@clux clux added the critical issues that will be added to release notes label Aug 7, 2021
clux added a commit that referenced this issue Aug 9, 2021
@clux
bump k8s-openapi 0.13.0 and revert option unpacking - fixes #581
30abcec 
reverts most of #531 while bumping k8s-openapi for https://github.com/Arnavion/k8s-openapi/releases/tag/v0.13.0

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux closed this as completed in ae92f05 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Api abstraction related bug Something isn't working critical issues that will be added to release notes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clux