fix: #[kube(crates(serde = "some_crate::serde"))] was not working
#1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I broke the test. Will investigate. |
because: - Usage of `serde` should be interpolated as `#serde` - `#[serde(crate = "some_crate::serde")]` should be added to generated struct Signed-off-by: chubei <914745487@qq.com>
|
Updated. |
chubei
changed the title
#[kube(crates = "some_crate::serde")] was not working#[kube(crates(serde = "some_crate::serde"))] was not working
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
- Coverage 73.50% 73.49% -0.02%
==========================================
Files 68 68
Lines 5379 5380 +1
==========================================
Hits 3954 3954
- Misses 1425 1426 +1
|
clux
approved these changes
May 16, 2023
|
Thanks for the quick merge! When will the next releases be? |
|
Will probably try to make one next week. If you need this early, feel free to git pin via cargo. |
|
Released in 0.83. Busy couple of weeks 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#[kube(crates(serde = "some_crate::serde"))]Solution
- Usage ofserdeshould be interpolated as#serde#[serde(crate = "some_crate::serde")]should be added to generated structNot sure how to add a test becaues
kube-derivealready depends onserde.We can probably add another crate just for testing. Not sure if that's overshoot.